Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node: Fix failed attestation verification #2179

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Conversation

herr-seppia
Copy link
Member

No description provided.

@HDauven
Copy link
Member

HDauven commented Aug 22, 2024

This is the error I get on top of this change:

thread 'main' panicked at node/benches/accept.rs:180:26:
block to be verified: invalid Validation, vote = Vote: Valid(0101010101010101...0101010101010101), round = 1, iter = 0, seed = 0505050505050505...0505050505050505, sv = StepVotes { bitset: 67108863, aggregate_signature: Signature { signature: "b65562e4d072b2ae...0dc41c568648d7cb" } }, err = Verification error Invalid Signature

Stack backtrace:
   0: anyhow::error::<impl anyhow::Error>::msg
   1: dusk_consensus::quorum::verifiers::verify_step_votes::{{closure}}
   2: futures_executor::local_pool::block_on
   3: criterion::bencher::AsyncBencher<A,M>::iter
   4: <criterion::routine::Function<M,F,T> as criterion::routine::Routine<M,T>>::warm_up
   5: criterion::routine::Routine::sample
   6: criterion::analysis::common
   7: criterion::benchmark_group::BenchmarkGroup<M>::bench_function
   8: accept::main
   9: std::sys_common::backtrace::__rust_begin_short_backtrace
  10: std::rt::lang_start::{{closure}}
  11: core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once
             at /rustc/0f44eb32f1123ac93ab404d74c295263ce468343/library/core/src/ops/function.rs:284:13
  12: std::panicking::try::do_call
             at /rustc/0f44eb32f1123ac93ab404d74c295263ce468343/library/std/src/panicking.rs:552:40
  13: std::panicking::try
             at /rustc/0f44eb32f1123ac93ab404d74c295263ce468343/library/std/src/panicking.rs:516:19
  14: std::panic::catch_unwind
             at /rustc/0f44eb32f1123ac93ab404d74c295263ce468343/library/std/src/panic.rs:142:14
  15: std::rt::lang_start_internal::{{closure}}
             at /rustc/0f44eb32f1123ac93ab404d74c295263ce468343/library/std/src/rt.rs:148:48
  16: std::panicking::try::do_call
             at /rustc/0f44eb32f1123ac93ab404d74c295263ce468343/library/std/src/panicking.rs:552:40
  17: std::panicking::try
             at /rustc/0f44eb32f1123ac93ab404d74c295263ce468343/library/std/src/panicking.rs:516:19
  18: std::panic::catch_unwind
             at /rustc/0f44eb32f1123ac93ab404d74c295263ce468343/library/std/src/panic.rs:142:14
  19: std::rt::lang_start_internal
             at /rustc/0f44eb32f1123ac93ab404d74c295263ce468343/library/std/src/rt.rs:148:20
  20: std::rt::lang_start
  21: __libc_start_call_main
             at ./csu/../sysdeps/nptl/libc_start_call_main.h:58:16
  22: __libc_start_main_impl
             at ./csu/../csu/libc-start.c:360:3
  23: _start
stack backtrace:
   0: rust_begin_unwind
             at /rustc/0f44eb32f1123ac93ab404d74c295263ce468343/library/std/src/panicking.rs:645:5
   1: core::panicking::panic_fmt
             at /rustc/0f44eb32f1123ac93ab404d74c295263ce468343/library/core/src/panicking.rs:72:14
   2: core::result::unwrap_failed
             at /rustc/0f44eb32f1123ac93ab404d74c295263ce468343/library/core/src/result.rs:1653:5
   3: futures_executor::local_pool::block_on
   4: criterion::bencher::AsyncBencher<A,M>::iter
   5: <criterion::routine::Function<M,F,T> as criterion::routine::Routine<M,T>>::warm_up
   6: criterion::routine::Routine::sample
   7: criterion::analysis::common
   8: criterion::benchmark_group::BenchmarkGroup<M>::bench_function
   9: accept::main
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

Copy link
Contributor

@fed-franz fed-franz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@herr-seppia herr-seppia merged commit 20a9006 into master Aug 22, 2024
16 checks passed
@herr-seppia herr-seppia deleted the fix_failed_attestations branch August 22, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants